Optimize GetDuties to not call Eth1 functions #5516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ca, ok := committeeAssignments[idx] | ||
| if ok { | ||
| assignment.Committee = ca.Committee | ||
| assignment.Status = vs.assignmentStatus(idx, s) | ||
| assignment.ValidatorIndex = idx | ||
| assignment.PublicKey = pubKey |
There was a problem hiding this comment.
Are you still assigning PublicKey?
There was a problem hiding this comment.
Yeah, it's set by default on top, look at the collapsed code above.
terencechain
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #5493, while not directly optimizing block slot estimation, this change removes unneeded calls to Eth1 for every inactive validator when the result wasn't even used.
Note, this will change metrics how metrics are reported for
UNKNOWN_STATUSandDEPOSITED, now a validator isn't marked asDEPOSITEDin the metrics until it's deposit has been processed by the chain.