Update prysm.sh to use prysmaticlabs.com/releases #5528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
approved these changes
Apr 20, 2020
|
Hello, IMO we should check for a valid hash between github and the file downloaded from the prysmatic labs. An hacker may try to change the files from the prysmatic labs's website. It will have less discrete ways to change something on github without anyone noticing. Edit : NVM you ckeck the signature. It's secured :) 👍 |
|
Thanks @Yoldark34. #5543 is almost ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid github rate limiting which many users have experienced.
I'm planning to follow up on this with a PR that verifies the signatures as well.