Fix Panic in Discv5 #5554
Merged
Fix Panic in Discv5 #5554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayzluf
approved these changes
Apr 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #5554 +/- ##
===========================================
+ Coverage 12.98% 43.54% +30.55%
===========================================
Files 115 275 +160
Lines 9203 23325 +14122
===========================================
+ Hits 1195 10156 +8961
- Misses 7804 11309 +3505
- Partials 204 1860 +1656 |
terencechain
added a commit
that referenced
this pull request
Apr 22, 2020
This reverts commit c69f561.
terencechain
added a commit
that referenced
this pull request
Apr 22, 2020
This reverts commit c9a174b.
rauljordan
pushed a commit
that referenced
this pull request
Apr 23, 2020
* Starting * Revert "update commit hash (#5554)" This reverts commit c69f561. * Various memory fixes * Revert "Revert "update commit hash (#5554)"" This reverts commit c9a174b. * Better error message * Provide getters * Using it in DomainData * Fixed test * Tests * Comment * Update cache for regular mode Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the panic in #5513 by updating to a patched commit in our geth fork.