Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests in //beacon-chain/rpc/beacon #5559

Merged
merged 7 commits into from
Apr 21, 2020

Conversation

farazdagi
Copy link
Contributor

@farazdagi farazdagi commented Apr 21, 2020

Problem: bazel test //beacon-chain/rpc/beacon:go_default_test results in the following:
image

This PR resolves it.

@farazdagi farazdagi requested a review from a team as a code owner April 21, 2020 14:41
@farazdagi farazdagi self-assigned this Apr 21, 2020
Copy link
Contributor

@shayzluf shayzluf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

shayzluf
shayzluf previously approved these changes Apr 21, 2020
Copy link
Contributor

@shayzluf shayzluf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can help a test halper function that does this

@farazdagi
Copy link
Contributor Author

maybe we can help a test halper function that does this

yep, to avoid unnecessary duplication. will do.

@prylabs-bulldozer prylabs-bulldozer bot merged commit 0f08bd2 into master Apr 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-list-indexed-atts-test branch April 21, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants