Remove Old Sync Routine #5761
Merged
Remove Old Sync Routine #5761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
approved these changes
May 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #5761 +/- ##
===========================================
+ Coverage 4.56% 54.56% +50.00%
===========================================
Files 241 309 +68
Lines 21247 25533 +4286
===========================================
+ Hits 969 13933 +12964
+ Misses 20126 9552 -10574
- Partials 152 2048 +1896 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes our old sync routine due to the current sync queue method having been the default for a few weeks now without any incident. This also removes a feature flag which disabled the new initial sync method.