Validate slashings upon pool exit #5848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5848 +/- ##
==========================================
+ Coverage 59.93% 59.94% +0.01%
==========================================
Files 312 312
Lines 26213 26235 +22
==========================================
+ Hits 15710 15726 +16
- Misses 8366 8368 +2
- Partials 2137 2141 +4 |
rauljordan
reviewed
May 14, 2020
endtoend/minimal_e2e_test.go
Outdated
| ev.PeersConnect, | ||
| ev.HealthzCheck, | ||
| //ev.PeersConnect, | ||
| //ev.HealthzCheck, |
…to validate-slashing
rauljordan
approved these changes
May 14, 2020
michaelhly
pushed a commit
to michaelhly/prysm
that referenced
this pull request
May 14, 2020
* Validate slashings upon pool exit * Change in implementation * Fix test * Merge branch 'master' into validate-slashing * Merge refs/heads/master into validate-slashing * Merge refs/heads/master into validate-slashing * Merge refs/heads/master into validate-slashing * Undo e2e changes * Merge branch 'validate-slashing' of github.com:prysmaticlabs/prysm into validate-slashing * Merge refs/heads/master into validate-slashing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Improvement
What does this PR do? Why is it needed?
This PR validates proposer and attester slashings upon exit of the pool, as they may have been processed after they were entered into that beacon nodes pool.
Also adds a regression test.
Which issues(s) does this PR fix?
Fixes #5731