Return Status And Goodbye for Different Fork Digests #5852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5852 +/- ##
==========================================
- Coverage 59.96% 59.92% -0.04%
==========================================
Files 312 312
Lines 26190 26211 +21
==========================================
+ Hits 15705 15708 +3
- Misses 8349 8367 +18
Partials 2136 2136 |
rauljordan
approved these changes
May 14, 2020
michaelhly
pushed a commit
to michaelhly/prysm
that referenced
this pull request
May 14, 2020
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
Currently we abruptly disconnect with a peer upon finding out that they are of a different fork. The correct way would be to send them our corresponding status and send them a correct goodbye message and then disconnect with them.
Which issues(s) does this PR fix?
Fixes #5740
Other notes for review