Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove out of date scripts and fix mockgen script #5859

Merged
merged 2 commits into from May 14, 2020
Merged

Conversation

0xKiwi
Copy link
Contributor

@0xKiwi 0xKiwi commented May 14, 2020

What type of PR is this?
Improvement

What does this PR do? Why is it needed?
This PR gets rid of the unused and out-of-date scripts we maintain in prysm and fixes the mockgen script.

Which issues(s) does this PR fix?
Fixes #5823

@0xKiwi 0xKiwi requested a review from a team as a code owner May 14, 2020 21:13
@terencechain
Copy link
Member

@terencechain
Copy link
Member

script failed for me: https://gist.github.com/terencechain/22aef4e4bc030431f40f048b5e6579fe

Sorry ignore this. Ethapi repo was pointed to the wrong commit

@0xKiwi 0xKiwi added the Ready For Review A pull request ready for code review label May 14, 2020
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow up, we should make sure prysm uses the right mock repo

@rauljordan rauljordan merged commit 52c3023 into master May 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the cleanup-scripts branch May 14, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update-mockgen script is oudated
3 participants