Handle missing archived index #5899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKiwi
reviewed
May 18, 2020
| archivedIndex := uint64(0) | ||
| if slot/params.BeaconConfig().SlotsPerArchivedPoint > 1 { | ||
| archivedIndex = slot/params.BeaconConfig().SlotsPerArchivedPoint - 1 | ||
| } | ||
| return s.beaconDB.ArchivedPointRoot(ctx, archivedIndex) | ||
| fmt.Println(archivedIndex) |
There was a problem hiding this comment.
I see this number increasing constantly, reached 130 and I turned off my slasher.
There was a problem hiding this comment.
That's good. That means your slasher is doing work 👍 I removed the debug log
0xKiwi
previously approved these changes
May 18, 2020
| if s.beaconDB.HasArchivedPoint(ctx, archivedIndex) { | ||
| return s.beaconDB.ArchivedPointRoot(ctx, archivedIndex), nil | ||
| } | ||
| archivedIndex-- |
There was a problem hiding this comment.
What is this? Can you add more to the godoc description about what this implementation is doing?
…abs/prysm into handle-missing-archived-index
Codecov Report
@@ Coverage Diff @@
## master #5899 +/- ##
==========================================
+ Coverage 59.83% 60.13% +0.30%
==========================================
Files 314 314
Lines 26505 26431 -74
==========================================
+ Hits 15858 15895 +37
+ Misses 8486 8391 -95
+ Partials 2161 2145 -16 |
0xKiwi
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
When an archived slot has a skip block, the node should be looking back to last archived slot to get a real root instead of returning
0x0000...This also handles genesis case instead of returning0x0000...Which issues(s) does this PR fix?
Fixes #5898
Other notes for review
Tested locally. Was able to request previously failed historical states via debug end point