Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BLS to allow for spec v0.12 requirements #5914

Merged
merged 6 commits into from May 23, 2020
Merged

Update BLS to allow for spec v0.12 requirements #5914

merged 6 commits into from May 23, 2020

Conversation

prestonvanloon
Copy link
Member

@prestonvanloon prestonvanloon commented May 19, 2020

What type of PR is this?

Feature

What does this PR do? Why is it needed?

Part of v0.12 spec updates.

Which issues(s) does this PR fix?

N/A

Other notes for review

This is safe to go into master since the curve type is configured at runtime and has not been updated.

Marking as blocked while we wait for response on herumi/bls-eth-go-binary#17

@prestonvanloon prestonvanloon added Blocked Blocked by research or external factors v0.12 labels May 19, 2020
@prestonvanloon prestonvanloon self-assigned this May 19, 2020
@prestonvanloon prestonvanloon removed the Blocked Blocked by research or external factors label May 23, 2020
@prestonvanloon prestonvanloon marked this pull request as ready for review May 23, 2020 02:21
@prestonvanloon prestonvanloon added the Ready For Review A pull request ready for code review label May 23, 2020
@prestonvanloon
Copy link
Member Author

To update v0.12 branch to use the new BLS curve, change this line to use draft07.

if err := bls12.SetETHmode(bls12.EthModeDraft05); err != nil {

@prestonvanloon prestonvanloon requested review from a team, shayzluf, 0xKiwi and terencechain and removed request for a team May 23, 2020 02:24
@nisdas nisdas merged commit 5a3114c into master May 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the update-bls branch May 23, 2020 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants