Log Active Validator Count #5923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5923 +/- ##
==========================================
- Coverage 59.76% 59.43% -0.34%
==========================================
Files 320 318 -2
Lines 27420 26754 -666
==========================================
- Hits 16387 15900 -487
+ Misses 8825 8704 -121
+ Partials 2208 2150 -58 |
shayzluf
reviewed
May 20, 2020
shayzluf
reviewed
May 20, 2020
| @@ -191,7 +191,14 @@ func (s *Service) ProcessDepositLog(ctx context.Context, depositLog gethTypes.Lo | |||
| if !s.chainStartData.Chainstarted { | |||
| deposits := len(s.chainStartData.ChainstartDeposits) | |||
| if deposits%512 == 0 { | |||
| log.WithField("deposits", deposits).Info("Processing deposits from Ethereum 1 chain") | |||
| valCount, err := helpers.ActiveValidatorCount(s.preGenesisState, 0) | |||
There was a problem hiding this comment.
isn't pre genesis state always the same?
There was a problem hiding this comment.
no its not, it is updated with every deposit
Co-authored-by: Shay Zluf <thezluf@gmail.com>
rauljordan
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Improve Logging
What does this PR do? Why is it needed?
Log Active Validator Count alongside total deposit count.
Which issues(s) does this PR fix?
N.A
Other notes for review
N.A