Return err instead of 0 for unavailable participation #5934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5934 +/- ##
==========================================
- Coverage 59.47% 59.40% -0.08%
==========================================
Files 318 318
Lines 26796 26796
==========================================
- Hits 15938 15917 -21
- Misses 8696 8720 +24
+ Partials 2162 2159 -3 |
0xKiwi
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
If the participation info of an epoch is not yet available (ie due to skip blocks, node processes epoch based on new block, not based on time), the node should return an
unavailableerror, instead of return new struct with all fields initialized to 0s. This has been confusing to many users, they often asked, why my node reported 0 stake was participated.