Reverse broadcast-slashing flag to disable-broadcast-slashings #5952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKiwi
changed the title
|
Test failed @0xKiwi |
Codecov Report
@@ Coverage Diff @@
## master #5952 +/- ##
==========================================
+ Coverage 59.47% 59.56% +0.09%
==========================================
Files 319 318 -1
Lines 26820 26777 -43
==========================================
- Hits 15950 15949 -1
+ Misses 8706 8662 -44
- Partials 2164 2166 +2 |
terencechain
requested changes
May 22, 2020
| @@ -4,16 +4,19 @@ import ( | |||
| "context" | |||
| "testing" | |||
|
|
|||
| "github.com/prysmaticlabs/prysm/shared/featureconfig" | |||
|
|
|||
shared/featureconfig/config.go
Outdated
| @@ -197,9 +197,9 @@ func ConfigureBeaconChain(ctx *cli.Context) { | |||
| log.Warn("Enabling state reference copy") | |||
| cfg.EnableStateRefCopy = true | |||
| } | |||
| if ctx.Bool(broadcastSlashingFlag.Name) { | |||
| if ctx.Bool(disableBroadcastSlashingFlag.Name) { | |||
| log.Warn("Enabling broadcast slashing to p2p network") | |||
There was a problem hiding this comment.
This log message doesn't seem right
There was a problem hiding this comment.
Good catch, thank you
…m into toggle-broadcast-flag
|
PTAL @terencechain |
terencechain
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Flag reversal
What does this PR do? Why is it needed?
This PR deprecates the
--broadcast-slashingflag, and introduces a--disable-broadcast-slashingsthat blocks slashings that are submitted into the beacon pool from being propagated. Reversing allows every node with a slasher to by default, propagate the slashings submitted.