Remove unused code #6065
Merged
Remove unused code #6065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Enhancement
prestonvanloon
requested changes
May 31, 2020
shared/bytesutil/bytes.go
Outdated
| @@ -79,14 +79,6 @@ func FromBytes8(x []byte) uint64 { | |||
| // LowerThan returns true if byte slice x is lower than byte slice y. (little-endian format) | |||
There was a problem hiding this comment.
Need to delete the comments too?
shared/bytesutil/bytes.go
Outdated
| @@ -186,17 +178,6 @@ func FromBytes48Array(x [][48]byte) [][]byte { | |||
| } | |||
|
|
|||
| // Xor xors the bytes in x and y and returns the result. | |||
shared/hashutil/hash.go
Outdated
| @@ -104,12 +104,6 @@ func HashKeccak256(data []byte) [32]byte { | |||
|
|
|||
| // RepeatHash applies the sha256 hash function repeatedly | |||
shared/testutil/log.go
Outdated
| @@ -45,25 +44,3 @@ func assertLogs(t *testing.T, hook *test.Hook, want string, flag bool) { | |||
| // WaitForLog waits for the desired string to appear the logs within a | |||
oops sorry, just realized using goland's delete button did not delete the comments |
prestonvanloon
approved these changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sunday funday code cleaning continue 馃Ч
This PR removes the unused code via Goland inspection馃Ч