Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes subsequence matching in deleteValueForIndices #6071

Merged
merged 3 commits into from Jun 1, 2020
Merged

Fixes subsequence matching in deleteValueForIndices #6071

merged 3 commits into from Jun 1, 2020

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

  • Additional check is added to make sure that deleteValueForIndices doesn't match root to subsequences of adjacent values.

Which issues(s) does this PR fix?

Fixes #6034

Other notes for review

  • Change is trivial, tests took some time!

rauljordan
rauljordan approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@rauljordan rauljordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, great regression tests!

@farazdagi farazdagi marked this pull request as ready for review June 1, 2020 17:35
@farazdagi farazdagi requested a review from a team as a code owner June 1, 2020 17:35
@farazdagi farazdagi requested a review from 0xKiwi June 1, 2020 17:35
@farazdagi farazdagi self-assigned this Jun 1, 2020
@farazdagi farazdagi added OK to merge Ready For Review A pull request ready for code review labels Jun 1, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit 4ed0e43 into master Jun 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-delete-value-for-indices branch June 1, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@terencechain terencechain Awaiting requested review from terencechain

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

Assignees

@farazdagi farazdagi

Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in DB deleteValueForIndices
2 participants
@farazdagi @rauljordan