Add Sync Pool For Snappy #6085
Merged
Add Sync Pool For Snappy #6085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
previously approved these changes
Jun 2, 2020
terencechain
reviewed
Jun 2, 2020
terencechain
previously approved these changes
Jun 2, 2020
prestonvanloon
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Improvement
What does this PR do? Why is it needed?
Currently for each instance of a snappy reader/writer it allocates 100 kb of memory. This is very expensive to do often and is a potential DOS vector as we receive multiple p2p rpc requests over the wire. To mitigate this we instead use a sync pool so that the reader and writer can be constantly re-used and memory does not have to be constantly allocated.
Which issues(s) does this PR fix?
N.A
Other notes for review
N.A