Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Updated Connection Manager #6184

Merged
merged 9 commits into from Jun 10, 2020
Merged

Use Updated Connection Manager #6184

merged 9 commits into from Jun 10, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Jun 9, 2020

What type of PR is this?

Feature Improvement

What does this PR do? Why is it needed?

With discoveryV5 being the default in v0.12 , we can throttle active discovery and
utilize the connection manager to prune any new inbound excess peers.

  • Add a peer buffer for our high watermark, so that inbound connections are still
    reasonably possible for new nodes entering the network
  • Have a 2 minute grace period to allow for any new peers to join and connect without running
    the risk of being trimmed..
  • Remove the requirement for aggressively disconnecting once the peer limit has been reached.
  • Remove forked connection manager.

Which issues(s) does this PR fix?

Is part of #5864 and resolves #5588 .

Other notes for review

@nisdas nisdas requested a review from a team as a code owner June 9, 2020 14:35
@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #6184 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6184   +/-   ##
=======================================
  Coverage   59.91%   59.91%           
=======================================
  Files         323      323           
  Lines       27612    27612           
=======================================
  Hits        16544    16544           
  Misses       8835     8835           
  Partials     2233     2233           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not reject peers if --p2p-max-peers is reached
3 participants