Add a Log for Newly Connected gRPC Clients in the Beacon Node #6233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
approved these changes
Jun 12, 2020
lee51525125
pushed a commit
to lee51525125/prysm
that referenced
this pull request
Jun 15, 2020
…ticlabs#6233) * interceptor disable logging via feature flag * Merge branch 'master' into validator-connection-logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This PR adds the ability to log new grpc client connections to beacon nodes:
Helping give feedback to users that their validator client is properly connected. This feature can be disabled with
--disable-grpc-connection-logsWhich issues(s) does this PR fix?
Fixes #5647, which brought up that we log p2p peer connections and disconnections but do not do the same for gRPC client connections (i.e. validator clients).