Fix ancestor to return most recent root in the case of skip slot #6242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
approved these changes
Jun 14, 2020
lee51525125
pushed a commit
to lee51525125/prysm
that referenced
this pull request
Jun 15, 2020
…smaticlabs#6242) * Revert "remove excess copies (prysmaticlabs#6142)" This reverts commit c956905. * Update ancestor function to handle skip slot * Test * Revert "Revert "remove excess copies (prysmaticlabs#6142)"" This reverts commit f1222b5. * Merge refs/heads/master into fix-ancestor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
The
ancestorfunction is old and hasn't been updated in a while. In the event of a skip slot, theancestorfunction should return most recent root prior to slot. Instead, it was returning nil.Other notes for review
Tested run time to and verified it fixed
FFG and LMD votes are not consistentissue