Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default BeaconRPCProvider for Validator Should Match Beacon Node's Host #6268

Merged
merged 2 commits into from
Jun 15, 2020

Conversation

rauljordan
Copy link
Contributor

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

Our beacon node binds its RPC host by default to 127.0.0.1 but our validator tries to connect to localhost, which causes some issues in containerized deployments. This PR ensures both match, making validators bind on 127.0.0.1 by default.

Which issues(s) does this PR fix?

Fixes #6238

@rauljordan rauljordan requested a review from a team as a code owner June 15, 2020 16:29
@rauljordan rauljordan self-assigned this Jun 15, 2020
@rauljordan rauljordan added the Ready For Review A pull request ready for code review label Jun 15, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit 83d1aa8 into master Jun 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the validator-localhost branch June 15, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validator resolved 'localhost' to [::1] and could not connect
2 participants