Less restrictive block stream for slashing detection #6269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayzluf
changed the title
0xKiwi
reviewed
Jun 15, 2020
0xKiwi
reviewed
Jun 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #6269 +/- ##
==========================================
- Coverage 60.07% 59.96% -0.11%
==========================================
Files 323 325 +2
Lines 27422 27643 +221
==========================================
+ Hits 16473 16576 +103
- Misses 8733 8794 +61
- Partials 2216 2273 +57 |
0xKiwi
reviewed
Jun 17, 2020
terencechain
previously approved these changes
Jun 17, 2020
0xKiwi
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
after #6164 has been reverted this PR is aiming to move validation responsibility of streamed block to rpc function (stream blocks). it adds StateSummaryCache to rpc service in order to handle validation of recent states using the new state gen.
Which issues(s) does this PR fix?
Fixes #6163
Other notes for review
block sig validation is dependant on new state get