Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix underflow in SlotsSinceGenesis #6275

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Fix underflow in SlotsSinceGenesis #6275

merged 2 commits into from
Jun 15, 2020

Conversation

prestonvanloon
Copy link
Member

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

This PR fixes an underflow condition for SlotsSinceGenesis computation.

Which issues(s) does this PR fix?

Fixes #6273

Other notes for review

@prestonvanloon prestonvanloon requested a review from a team as a code owner June 15, 2020 21:25
@prestonvanloon prestonvanloon added the Ready For Review A pull request ready for code review label Jun 15, 2020
terencechain
terencechain previously approved these changes Jun 15, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit 8097eea into master Jun 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-underflow2 branch June 15, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SlotsSinceGenesis can underflow pre-genesis
2 participants