pre-allocate memory for AggregateVerify #6285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
added
OK to merge
Ready For Review
terencechain
approved these changes
Jun 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #6285 +/- ##
==========================================
- Coverage 60.00% 59.92% -0.09%
==========================================
Files 328 325 -3
Lines 28146 27634 -512
==========================================
- Hits 16890 16559 -331
+ Misses 8926 8806 -120
+ Partials 2330 2269 -61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This PR allocates the correct amount of memory so that the slices created in AggregateVerify have the correct capacity.
Which issues(s) does this PR fix?
Helps for #5176
Other notes for review
Tested at runtime with negligible improvements to init sync.