Remove redundant check in exit.go #6559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check `exit.Exit.ValidatorIndex >= uint64(beaconState.NumValidators())` is done in `beaconState.ValidatorAtIndexReadOnly(exit.Exit.ValidatorIndex)`.
|
|
Codecov Report
@@ Coverage Diff @@
## master #6559 +/- ##
==========================================
- Coverage 61.97% 61.78% -0.19%
==========================================
Files 367 366 -1
Lines 28799 28624 -175
==========================================
- Hits 17848 17686 -162
- Misses 8523 8525 +2
+ Partials 2428 2413 -15 |
JustinDrake
added a commit
to JustinDrake/prysm
that referenced
this pull request
Jul 13, 2020
The number of indices, by construction, will be no more than `MAX_VALIDATORS_PER_COMMITTEE` because the SSZ type of `indexedAttestation.AttestingIndices` is a list with max size `MAX_VALIDATORS_PER_COMMITTEE`. This is a minor cleanup similar to prysmaticlabs#6559.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check
exit.Exit.ValidatorIndex >= uint64(beaconState.NumValidators())is done inbeaconState.ValidatorAtIndexReadOnly(exit.Exit.ValidatorIndex). This is a minor cleanup.