Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes display issue in testutils/assert #6585

Merged
merged 1 commit into from Jul 13, 2020
Merged

Fixes display issue in testutils/assert #6585

merged 1 commit into from Jul 13, 2020

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

  • Fixes minor display issue where full path of tested file is displayed on error:
    image
  • Also updates the file being displayed to the one that failed (not one calling assertion)

Which issues(s) does this PR fix?

N/A

Other notes for review

@farazdagi farazdagi added Ready For Review A pull request ready for code review OK to merge labels Jul 13, 2020
@farazdagi farazdagi requested a review from a team as a code owner July 13, 2020 17:03
@farazdagi farazdagi self-assigned this Jul 13, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit d1e754f into master Jul 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the assert-minor-fix branch July 13, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain approved these changes

@shayzluf shayzluf Awaiting requested review from shayzluf

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

Assignees

@farazdagi farazdagi

Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@farazdagi @terencechain