Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts V2: Create Wallet Non-Interactively + Add Test Coverage #6611

Merged
merged 5 commits into from Jul 17, 2020

Conversation

rauljordan
Copy link
Contributor

What type of PR is this?

Feature

What does this PR do? Why is it needed?

This PR allows us to run prysm validator wallet-v2 create non-interactively with a pure, flag-based setup.

Remote Keymanager Wallet Creation

bazel run //validator -- wallet-v2 create \
  --wallet-dir=/tmp/wallet \
  --passwords-dir=/tmp/walletpasswords \
  --keymanager-kind=remote \
  --grpc-remote-address=host.example.com:4000 \
  --remote-signer-crt-path=/tmp/client.crt \
   --remote-signer-key-path=/tmp/client.key \
   --remote-signer-ca-crt-path=/tmp/ca.crt

Direct Keymanager Wallet Creation

bazel run //validator -- wallet-v2 create \
  --wallet-dir=/tmp/wallet \
  --passwords-dir=/tmp/walletpasswords \
  --keymanager-kind=direct

Which issues(s) does this PR fix?

Part of #6220

@rauljordan rauljordan marked this pull request as ready for review July 15, 2020 23:21
@rauljordan rauljordan requested a review from a team as a code owner July 15, 2020 23:21
@rauljordan rauljordan marked this pull request as draft July 15, 2020 23:21
@rauljordan rauljordan marked this pull request as ready for review July 16, 2020 20:11
@rauljordan rauljordan self-assigned this Jul 16, 2020
@rauljordan rauljordan added AccountsV2 Ready For Review A pull request ready for code review labels Jul 16, 2020
@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #6611 into master will increase coverage by 1.48%.
The diff coverage is 71.60%.

@@            Coverage Diff             @@
##           master    #6611      +/-   ##
==========================================
+ Coverage   60.07%   61.56%   +1.48%     
==========================================
  Files         323      373      +50     
  Lines       27422    29239    +1817     
==========================================
+ Hits        16473    18000    +1527     
- Misses       8733     8770      +37     
- Partials     2216     2469     +253     

@prylabs-bulldozer prylabs-bulldozer bot merged commit 9ad6277 into master Jul 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the create-wallet-tests branch July 17, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants