Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applies assertion funcs to cache tests #6617

Merged
merged 6 commits into from Jul 16, 2020

Conversation

rkapka
Copy link
Contributor

@rkapka rkapka commented Jul 16, 2020

What type of PR is this?

Other/Tests Refactoring

What does this PR do? Why is it needed?

applies testutil/assert and testutil/require to cache tests

Which issues(s) does this PR fix?

Part of #6590

Other notes for review

I don't know how to assert that a slice variable is nil. Trying assert.Equal(t, ([]unit64)(nil), x) results in

panic: runtime error: comparing uncomparable type []uint64 [recovered]
        panic: runtime error: comparing uncomparable type []uint64

@rkapka rkapka requested a review from a team as a code owner July 16, 2020 15:41
@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #6617 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6617      +/-   ##
==========================================
- Coverage   61.50%   61.42%   -0.09%     
==========================================
  Files         375      373       -2     
  Lines       29298    29237      -61     
==========================================
- Hits        18021    17958      -63     
- Misses       8819     8820       +1     
- Partials     2458     2459       +1     

Copy link
Contributor

@farazdagi farazdagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@prylabs-bulldozer prylabs-bulldozer bot merged commit 77607c6 into prysmaticlabs:master Jul 16, 2020
@rkapka rkapka deleted the cache-test-refactor branch July 19, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants