Begin Dynamic Rescan of Validating Keys #6963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
added
AccountsV2
Enhancement
rauljordan
requested review from
nisdas,
prestonvanloon,
rkapka and
terencechain
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
rauljordan
commented
Aug 27, 2020
| @@ -83,6 +83,7 @@ this command outputs a deposit data string which is required to become a validat | |||
| "list of hex string public keys", | |||
| Flags: []cli.Flag{ | |||
| flags.WalletDirFlag, | |||
| flags.WalletPasswordFileFlag, | |||
There was a problem hiding this comment.
Turns out backup didn't have the wallet password file flag
rauljordan
changed the title
0xKiwi
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This PR adds a much requested feature of being able to dynamically add new validator keys while a validator client is running. We accomplish this to a process called
rescanning, which looks for changes to ourall-accounts.keystore.jsonfile. This allows for straightforward, dynamic key management for validator clients by allowing us to runaccounts-v2 importwhile a validator process is running.all-accounts.keystore.jsonand reloads validator keys at runtime if the file changed. This file can be changed by importing new keys into a running validator client by usingprysm.sh validator accounts-v2 importasyncutil, which adds the functionDebounceto a Go channel, allowing us to debounce a large number of events sent over a channel and instead only process a handler after a set interval passes.Which issues(s) does this PR fix?
Fixes #5202
Works at Runtime
Confirmed this functionality works at runtime. Started my validator client with a single key, then ran a script which runs
import1023 separate times for 1023 separate keystore files, and the validator client would debounce these changes after a period of time. Once it was all done, all 1024 keys were attesting.During import and debouncing (logs added for debug purposes)
After import complete, all keys attesting
