Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates resyncIfBehind() functionality #7039

Merged
merged 10 commits into from Aug 18, 2020
Merged

Updates resyncIfBehind() functionality #7039

merged 10 commits into from Aug 18, 2020

Conversation

farazdagi
Copy link
Contributor

@farazdagi farazdagi commented Aug 17, 2020

What type of PR is this?

Other/Extension (due to amended assumptions)

What does this PR do? Why is it needed?

  • Currently, resync only happens if node falls behind majority of finalized peers. In situations of long periods of non-finality, no peers will be far away, consequently resync never happens (so the 2nd stage of init-sync never re-triggered). This PR fixes that.

Which issues(s) does this PR fix?

Fixes #

Other notes for review

  • We check peers to see if majority have some head slot towards which node can work. And when such peers are found -- resync is triggered.

@farazdagi farazdagi marked this pull request as ready for review August 17, 2020 23:06
@farazdagi farazdagi requested a review from a team as a code owner August 17, 2020 23:06
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #7039 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7039   +/-   ##
=======================================
  Coverage   62.58%   62.58%           
=======================================
  Files         401      401           
  Lines       31722    31722           
=======================================
  Hits        19854    19854           
  Misses       9089     9089           
  Partials     2779     2779           

@farazdagi farazdagi self-assigned this Aug 18, 2020
@farazdagi farazdagi added the Ready For Review A pull request ready for code review label Aug 18, 2020
nisdas
nisdas previously approved these changes Aug 18, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit 0a5ec50 into master Aug 18, 2020
@nisdas nisdas deleted the fix-resync branch August 18, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants