Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharding P2P Protocol Specs Proposition #72

Closed
rauljordan opened this issue Mar 14, 2018 · 9 comments
Closed

Sharding P2P Protocol Specs Proposition #72

rauljordan opened this issue Mar 14, 2018 · 9 comments

Comments

@rauljordan
Copy link
Contributor

Hi Team,

As part of this issue I would like to propose we use libp2p as our sharding networking protocol. It is a solid library created by Protocol Labs and currently powering IPFS. Let's use this issue to elaborate on this as much as we can and discuss if we want to integrate this.

Let's figure out how different it is from devp2p and if it would be worth our while to try this approach.

Here are some of the resources to get started:

libp2p site
libp2p specs
go libp2p
js libp2p

distinction between p2p libraries
libp2p video by juan benet
devp2p wiki

Let me know your thoughts below.

@terencechain
Copy link
Member

Check out Felix's slide on evolving devp2p from devcon3:
https://twurst.com/files/devcon3-evolving-devp2p.pdf

Also WhisperV6 runs on libp2p because whisper peering sucks on devp2p

@Magicking
Copy link
Contributor

Magicking commented Mar 14, 2018 via email

@nisdas
Copy link
Member

nisdas commented Mar 21, 2018

I did an overview summarizing what devp2p and libp2p would entail , you guys can take a look for it here https://docs.google.com/document/d/1K9NVV2SBjxdgejWnip3l-ZYyknOdWu6i5Ot_X_y6t1k/edit?usp=sharing

I am in agreement with Raul that for us using libp2p would be a better option than devp2p owing to the fact the former has more robust documentation , libp2p was designed to be able to use a much wider variety of transport protocols and is transport agnostic. Also the team at protocol labs is consistently working on it and improving on it which is beneficial to us. In comparison devp2p has very sparse documentation and does not look like it is being actively maintained.

@Magicking
Copy link
Contributor

As I re-read this issue, there is also something missing as libp2p or devp2p would only be the network layer where we also need a protocol specification to define the standard communication mecanism, it's certainly an issue we should tackle upstream (https://ethresear.ch/c/sharding)

@enriquefynn
Copy link
Contributor

I think this should be pushed forward in the implementation. We don't need any p2p network for a local client.

@nisdas
Copy link
Member

nisdas commented Mar 23, 2018

We would need for our proposer node , since it is using a separate transaction pool to the main client

@enriquefynn enriquefynn modified the milestones: Ruby, Sapphire Mar 23, 2018
@enriquefynn
Copy link
Contributor

We don't need any p2p network for a local client, I'm pushing this to the sapphire release

@terencechain
Copy link
Member

We have been working with Libp2p for a while now. Ok to close this issue?

@prestonvanloon
Copy link
Member

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

6 participants