Update to Discovery V5.1 #7302
Merged
Update to Discovery V5.1 #7302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7302 +/- ##
==========================================
- Coverage 61.81% 61.58% -0.24%
==========================================
Files 424 424
Lines 30110 29815 -295
==========================================
- Hits 18614 18362 -252
+ Misses 8538 8512 -26
+ Partials 2958 2941 -17 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
@nisdas is this needed for Zinken? |
|
This pull request has been closed due to inactivity. Please reopen this pull request if you would like to continue working on it. |
… into discoveryV5.1
prestonvanloon
requested changes
Oct 19, 2020
Comment on lines
18
to
24
| _ = []interface{}{ | ||
| &pubkey, | ||
| &withdrawalCredentials, | ||
| &amount, | ||
| &signature, | ||
| &index, | ||
| } |
prestonvanloon
previously approved these changes
Oct 19, 2020
prestonvanloon
previously approved these changes
Oct 20, 2020
prestonvanloon
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Addition
What does this PR do? Why is it needed?
Updates Prysm to use DiscoveryV5.1 inline with this issue:
ethereum/consensus-specs#2059
Which issues(s) does this PR fix?
N.A
Other notes for review