Use Custom SSZ for P2P Types #7436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
terencechain
reviewed
Oct 8, 2020
| @@ -26,8 +26,6 @@ ssz_gen_marshal( | |||
| ], | |||
| objs = [ | |||
| "BeaconBlocksByRangeRequest", | |||
| "BeaconBlocksByRootRequest", | |||
There was a problem hiding this comment.
Delete BeaconBlocksByRootRequest in messages.proto?
There was a problem hiding this comment.
Its been deleted form before, this is just cleanup
beacon-chain/p2p/types/BUILD.bazel
Outdated
| name = "go_default_library", | ||
| srcs = ["types.go"], | ||
| importpath = "github.com/prysmaticlabs/prysm/beacon-chain/p2p/types", | ||
| visibility = ["//visibility:public"], |
There was a problem hiding this comment.
Should the visibility be public here?
There was a problem hiding this comment.
nice catch ! that is why the CI was complaining lol
… into useCustomSSZ
prestonvanloon
previously approved these changes
Oct 14, 2020
|
Conflicts 😭 PTAL @nisdas |
prestonvanloon
previously approved these changes
Oct 14, 2020
prestonvanloon
previously approved these changes
Oct 14, 2020
prestonvanloon
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Addition And Bug Fix
What does this PR do? Why is it needed?
go-sszfor non composite type whichled our node to be susceptible to any go-ssz specific bugs. This PR instead implements custom ssz for our
required p2p types, so that they do not need to use go-ssz anymore
Which issues(s) does this PR fix?
Fixes #7425
Other notes for review