Import old attestation store #7466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7466 +/- ##
==========================================
- Coverage 60.73% 60.57% -0.17%
==========================================
Files 427 427
Lines 30545 30383 -162
==========================================
- Hits 18550 18403 -147
- Misses 8982 8983 +1
+ Partials 3013 2997 -16 |
nisdas
reviewed
Oct 8, 2020
…bs/prysm into import_old_attestation_store
…ld_attestation_store
…bs/prysm into import_old_attestation_store
…ld_attestation_store
nisdas
reviewed
Oct 12, 2020
validator/db/kv/manage.go
Outdated
| last := 0 | ||
|
|
||
| next: | ||
| for _, k1 := range keys { | ||
| for _, k2 := range keys[:last] { | ||
| if bytes.Equal(k1, k2) { | ||
| if bytes.Equal(k1[:], k2[:]) { |
There was a problem hiding this comment.
if its a fixed sized array you can compare it directly.
nisdas
reviewed
Oct 12, 2020
…bs/prysm into import_old_attestation_store
nisdas
previously approved these changes
Oct 12, 2020
nisdas
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
What does this PR do? Why is it needed?
Data migration function from old attestation protection db data structure to new one
Which issues(s) does this PR fix?
Part of #7196
Other notes for review