Add show-private-keys flag to accounts-v2 list

[potuz]

This PR adds a --show-private-keys flag to validator accounts-v2 list so that if run on an HD wallet it shows the validating and withdrawal private keys, if run on a non-HD wallet it shows the validating private keys.

It fixes #7387

[prestonvanloon]

Looks like this doesn't compile. Please take a look. Thanks!

[prestonvanloon]

There are codepaths here that could exit without unlocking this lock. Please defer the unlocking of this lock

Suggested change

	func (dr *Keymanager) FetchValidatingPrivateKeys(ctx context.Context) ([][]byte, error) {
	dr.lock.RLock()
	privKeys := make([][]byte, len(dr.secretKeysCache))
	pubKeys, err := dr.FetchValidatingPublicKeys(ctx)
	if err != nil {
	return nil, errors.Wrap(err, "could not retrieve public keys")
	}
	for i, pk := range pubKeys {
	seckey, ok := dr.secretKeysCache[pk]
	if !ok {
	return nil, errors.New("Could not fetch private key")
	}
	privKeys[i] = seckey.Marshal()
	}
	dr.lock.RUnlock()
	return privKeys, nil
	}
	func (dr *Keymanager) FetchValidatingPrivateKeys(ctx context.Context) ([][]byte, error) {
	dr.lock.RLock()
	defer dr.lock.RUnlock()
	privKeys := make([][]byte, len(dr.secretKeysCache))
	pubKeys, err := dr.FetchValidatingPublicKeys(ctx)
	if err != nil {
	return nil, errors.Wrap(err, "could not retrieve public keys")
	}
	for i, pk := range pubKeys {
	seckey, ok := dr.secretKeysCache[pk]
	if !ok {
	return nil, errors.New("Could not fetch private key")
	}
	privKeys[i] = seckey.Marshal()
	}
	return privKeys, nil
	}

[prestonvanloon]

Any tests for this new method?

[prestonvanloon]

Any tests for this new method?

[rauljordan]

Where is this method used? Can we delete? Couldn't find any mentions of it

[potuz]

That was leftover from an old implementation cause you originally wanted to have a subcommand rather than a flag to accounts-v2 list. I forgot to remove it :(

[prestonvanloon]

Any tests for this new method?

[rauljordan]

This function can exit and return before unlocking, to fix this, let's do this at the top of the function:

lock.RLock()
defer lock.RUnlock()

[rauljordan]

This function does not acquire a read lock, let's do

lock.RLock()
defer lock.RUnlock()

at the top

[rauljordan]

Where is this method used? Can we delete? Couldn't find any mentions of it

[codecov]

Codecov Report

Merging #7487 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7487      +/-   ##
==========================================
- Coverage   61.83%   61.71%   -0.13%     
==========================================
  Files         422      421       -1     
  Lines       29527    29479      -48     
==========================================
- Hits        18259    18193      -66     
- Misses       8343     8371      +28     
+ Partials     2925     2915      -10