Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate imports #7491

Merged
merged 3 commits into from
Oct 10, 2020
Merged

Remove duplicate imports #7491

merged 3 commits into from
Oct 10, 2020

Conversation

farazdagi
Copy link
Contributor

@farazdagi farazdagi commented Oct 10, 2020

What type of PR is this?

Other

What does this PR do? Why is it needed?

  • Go allows importing the same package under different aliases, however, this is randomly intentional (only when we deliberately want to expose methods under different scopes, say, preparing for the future refactoring).
  • This PR removes multiple imports of the same packages, where they seem to be introduced unintentionally.

Which issues(s) does this PR fix?

N/A

Other notes for review

  • With imports of state, I opted for stateTrie variant as it is less likely to be shadowed by local vars (it is easy to imagine how one defines local var named state which overshadows imported package name; stateTrie is less likely for a local name).

@farazdagi farazdagi added Ready For Review A pull request ready for code review OK to merge Cleanup Code health! labels Oct 10, 2020
@farazdagi farazdagi requested a review from a team as a code owner October 10, 2020 01:54
@farazdagi farazdagi self-assigned this Oct 10, 2020
@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #7491 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7491   +/-   ##
=======================================
  Coverage   60.74%   60.74%           
=======================================
  Files         426      426           
  Lines       30485    30485           
=======================================
  Hits        18517    18517           
  Misses       8950     8950           
  Partials     3018     3018           

@prylabs-bulldozer prylabs-bulldozer bot merged commit 4c09e59 into master Oct 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the remove-redundant-imports branch October 10, 2020 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Code health! Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants