Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combines func params of the same type #7500

Merged
merged 5 commits into from
Oct 12, 2020
Merged

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Other

What does this PR do? Why is it needed?

  • Arguments of the same type can be combined in Go, this PR resolves for all occurrences (see DeepSource report).

Which issues(s) does this PR fix?

N/A

Other notes for review

@farazdagi farazdagi added the Ready For Review A pull request ready for code review label Oct 12, 2020
@farazdagi farazdagi self-assigned this Oct 12, 2020
@farazdagi farazdagi added Cleanup Code health! and removed Ready For Review A pull request ready for code review labels Oct 12, 2020
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #7500 into master will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7500      +/-   ##
==========================================
- Coverage   60.64%   60.51%   -0.13%     
==========================================
  Files         427      427              
  Lines       30505    30344     -161     
==========================================
- Hits        18499    18364     -135     
+ Misses       8989     8985       -4     
+ Partials     3017     2995      -22     

@farazdagi farazdagi marked this pull request as ready for review October 12, 2020 10:10
@farazdagi farazdagi requested a review from a team as a code owner October 12, 2020 10:10
@farazdagi farazdagi added OK to merge Ready For Review A pull request ready for code review labels Oct 12, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit a019a0d into master Oct 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the combine-arg-types branch October 12, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Code health! Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants