Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reported anti patterns #7501

Merged
merged 13 commits into from
Oct 12, 2020
Merged

Fix reported anti patterns #7501

merged 13 commits into from
Oct 12, 2020

Conversation

farazdagi
Copy link
Contributor

@farazdagi farazdagi commented Oct 12, 2020 •
edited

What type of PR is this?

Other

What does this PR do? Why is it needed?

Which issues(s) does this PR fix?

N/A

Other notes for review

  • Cases of single case channel selects have been resolved by adding extra case allowing to unblock on context close.

@farazdagi farazdagi added the Cleanup Code health! label Oct 12, 2020
@farazdagi farazdagi self-assigned this Oct 12, 2020
@farazdagi farazdagi marked this pull request as ready for review October 12, 2020 12:37
@farazdagi farazdagi requested a review from a team as a code owner October 12, 2020 12:37
@farazdagi farazdagi added OK to merge Ready For Review A pull request ready for code review labels Oct 12, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit ac1a4a0 into master Oct 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-reported-anti-patterns branch October 12, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkapka rkapka rkapka approved these changes

@shayzluf shayzluf Awaiting requested review from shayzluf

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

Assignees

@farazdagi farazdagi

Labels
Cleanup Code health! Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@farazdagi @rkapka