Remove inital sync don't verify att sig flag #7517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
Codecov Report
@@ Coverage Diff @@
## master #7517 +/- ##
==========================================
- Coverage 60.68% 60.60% -0.09%
==========================================
Files 427 427
Lines 30444 30353 -91
==========================================
- Hits 18475 18394 -81
- Misses 8957 8965 +8
+ Partials 3012 2994 -18 |
nisdas
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7515
This PR removes
disable-initial-sync-verify-all-signatures. This is a very unsafe flag and we shouldn't have it for beta. This was nice to delete, it enabled us to delete old methods such asProcessBlockNoVerifyAttSigsandExecuteStateTransitionNoVerifyAttSigs