Use new proposal protection format #7518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…proposal_protection_format
9 tasks
…aticlabs/prysm into use_new_proposal_protection_format
|
@terencechain added link to pr description |
…aticlabs/prysm into use_new_proposal_protection_format
…proposal_protection_format # Conflicts: # validator/accounts/v1/BUILD.bazel # validator/accounts/v1/account_test.go # validator/client/propose.go # validator/client/propose_protect_test.go
Codecov Report
@@ Coverage Diff @@
## master #7518 +/- ##
==========================================
- Coverage 61.83% 61.69% -0.15%
==========================================
Files 422 422
Lines 29527 29493 -34
==========================================
- Hits 18259 18196 -63
- Misses 8343 8379 +36
+ Partials 2925 2918 -7 |
nisdas
reviewed
Oct 15, 2020
|
|
||
| for i, key := range pubKeys { | ||
| proposalHistory := bitfield.Bitlist{byte(i), 0x00, 0x00, 0x00, 0x01} | ||
| if err := store.SaveProposalHistoryForEpoch(context.Background(), key[:], 0, proposalHistory); err != nil { | ||
| signingRoot := bytesutil.PadTo([]byte{byte(i)}, 32) |
There was a problem hiding this comment.
this is confusing, why is the signing root the index of the pubkey ?
There was a problem hiding this comment.
Just to have different values
Co-authored-by: Nishant Das <nishdas93@gmail.com>
…aticlabs/prysm into use_new_proposal_protection_format
…aticlabs/prysm into use_new_proposal_protection_format
rauljordan
previously approved these changes
Oct 15, 2020
…proposal_protection_format # Conflicts: # validator/client/propose_protect.go # validator/client/propose_test.go
…aticlabs/prysm into use_new_proposal_protection_format
rauljordan
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Use the new proposal protection format in runtime
Why
As part of the effort to support slashing protection data interchange format and the need to add signing root to our protection db i have found that proposals db was built for the old slashing rule (1 proposal per epoch) since that rule changed to (1 proposal per slot) there is no benefit for saving this data on epoch context and adding complexity .
The new db structure saves proposals signing roots per slot for slashing protection.
Which issues(s) does this PR fix?
Part of #7196
data interchange format
https://hackmd.io/@sproul/Bk0Y0qdGD#Implementations