E2E cleanup #7519
Merged
E2E cleanup #7519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7519 +/- ##
=======================================
Coverage 60.65% 60.65%
=======================================
Files 430 430
Lines 30413 30413
=======================================
Hits 18448 18448
Misses 8972 8972
Partials 2993 2993 |
rkapka
added
OK to merge
Ready For Review
rkapka
commented
Oct 13, 2020
| @@ -29,29 +29,12 @@ const ( | |||
| maxFileBufferSize = 1024 * 1024 | |||
| ) | |||
|
|
|||
| // KillProcesses finds the passed in process IDs and kills the process. | |||
| func KillProcesses(t *testing.T, pIDs []int) { | |||
There was a problem hiding this comment.
Not sure if this is safe to remove.
rkapka
removed
OK to merge
Ready For Review
|
Marking as WIP because of flaky E2E tests. It might be that I removed something that shouldn't be removed. |
|
Last 5 build runs passed E2E. WIP removed. |
rauljordan
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Cleanup
What does this PR do? Why is it needed?
Perform cleanup in the
endtoendfolder.Which issues(s) does this PR fix?
N/A
Other notes for review
N/A