Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept ToS: fix #7539

Merged

Conversation

bidlocode
Copy link
Contributor

Emits a warning when run fresh without datadir and asks to accept ToS one more time after that. ToS acceptance procedure happens before anything else so datadir should be created.

Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add a test?

I wonder if we should put this check in the DB pkg so we don't have to create twice

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #7539 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7539      +/-   ##
==========================================
- Coverage   61.83%   61.78%   -0.05%     
==========================================
  Files         422      422              
  Lines       29714    29459     -255     
==========================================
- Hits        18374    18202     -172     
+ Misses       8394     8340      -54     
+ Partials     2946     2917      -29     

@bidlocode
Copy link
Contributor Author

bidlocode commented Oct 15, 2020

Modified test so it will test directory creation too. No need to create twice. In docs it says that os.MkdirAll() doesn't do anything if directory already exists.

@prestonvanloon
Copy link
Member

@terencechain there are tests already. If we ran these tests on CI for windows, it would have failed, but we only run linux agents at the moment.

@prylabs-bulldozer prylabs-bulldozer bot merged commit 7aaefd1 into prysmaticlabs:master Oct 15, 2020
@bidlocode bidlocode deleted the fix-accept-tos-create-datadir branch October 16, 2020 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants