Rename Accounts-V2 to Accounts #7545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
added
Accounts
Cleanup
rauljordan
requested review from
0xKiwi,
nisdas,
rkapka and
terencechain
and removed request for
terencechain and
rkapka
rkapka
reviewed
Oct 15, 2020
|
Thanks @rkapka fixed it up |
terencechain
previously approved these changes
Oct 15, 2020
0xKiwi
reviewed
Oct 15, 2020
Co-authored-by: Ivan Martinez <ivanthegreatdev@gmail.com>
0xKiwi
approved these changes
Oct 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #7545 +/- ##
==========================================
- Coverage 61.90% 61.67% -0.24%
==========================================
Files 422 423 +1
Lines 29776 29850 +74
==========================================
- Hits 18434 18410 -24
- Misses 8381 8479 +98
Partials 2961 2961 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #7515, in this PR we rename all instances of accounts-v2, wallet-v2, and keymanager-v2 to take away the suffix. This is a breaking release, and one of our last opportunities to make such a drastic change. No logic changes in this PR, only renaming and reshuffling of packages around.