Rename Direct Keymanager to Imported #7549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
commented
Oct 16, 2020
| @@ -43,7 +43,7 @@ func (k Kind) String() string { | |||
| switch k { | |||
| case Derived: | |||
| return "derived" | |||
| case Direct: | |||
| case Imported: | |||
| return "direct" | |||
There was a problem hiding this comment.
Not changed because it will break people's wallets
There was a problem hiding this comment.
If theres anytime to do this isn't it for the beta release?
terencechain
approved these changes
Oct 16, 2020
0xKiwi
approved these changes
Oct 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #7549 +/- ##
==========================================
+ Coverage 61.67% 61.81% +0.14%
==========================================
Files 424 424
Lines 29897 29897
==========================================
+ Hits 18439 18482 +43
+ Misses 8491 8447 -44
- Partials 2967 2968 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #7515. This PR Removes all instances of non-HD or direct wallets and renames them to
importedto reflect that they must be initialized by importing keystores from an external source