Don't show stack trace for certain voluntary exit failure scenarios #7554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
changed the title
rauljordan
approved these changes
Oct 16, 2020
rauljordan
reviewed
Oct 16, 2020
| @@ -171,6 +173,11 @@ this command outputs a deposit data string which is required to become a validat | |||
| Action: func(cliCtx *cli.Context) error { | |||
| featureconfig.ConfigureValidator(cliCtx) | |||
| if err := ExitAccountsCli(cliCtx, os.Stdin); err != nil { | |||
| msg := err.Error() | |||
There was a problem hiding this comment.
@rkapka let's use errors.Is instead of doing string comparisons
There was a problem hiding this comment.
errors.Is cannot be used here as I am not comparing errors. The exported messages are plain strings.
Codecov Report
@@ Coverage Diff @@
## master #7554 +/- ##
=======================================
Coverage 61.74% 61.74%
=======================================
Files 424 424
Lines 29944 29944
=======================================
Hits 18488 18488
Misses 8488 8488
Partials 2968 2968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Stack trace will not be displayed if validator could not be exited because of the following non-fatal reasons:
Which issues(s) does this PR fix?
Fixes #7534
Other notes for review
N/A