Fix Unsafe Sync Flag #7563
Merged
Fix Unsafe Sync Flag #7563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
approved these changes
Oct 18, 2020
| @@ -434,7 +434,7 @@ func (s *Service) initializeChainInfo(ctx context.Context) error { | |||
| if err != nil { | |||
| return errors.Wrap(err, "could not hash head block") | |||
| } | |||
| headState, err := s.beaconDB.HeadState(ctx) | |||
| headState, err := s.stateGen.StateByRoot(ctx, headRoot) | |||
There was a problem hiding this comment.
If headState in DB != headRoot generated state, then it is pretty concerning and makes me wonder if there's missing underlying bug. Can this behavior be reproduced by a test?
There was a problem hiding this comment.
Not exactly a test but right now in medalla. Our headstate is actually nil, which is why this never works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
N.A
Other notes for review