Update participation metrics #7582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to credit @potuz for some of the suggestions! 🙏 |
Codecov Report
@@ Coverage Diff @@
## master #7582 +/- ##
==========================================
- Coverage 61.84% 61.65% -0.19%
==========================================
Files 423 423
Lines 29697 29628 -69
==========================================
- Hits 18365 18268 -97
- Misses 8401 8439 +38
+ Partials 2931 2921 -10 |
rauljordan
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After chatting with @potuz. This PR updates participation metric to use
headview instead oflast_processedview. Since metrics are the only changes and this code path has been tested. I also verified run time and metrics were correctly representing head view