Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lighthouse p2p Good Bye codes #7601

Merged
merged 2 commits into from Oct 22, 2020
Merged

Add lighthouse p2p Good Bye codes #7601

merged 2 commits into from Oct 22, 2020

Conversation

prestonvanloon
Copy link
Member

What type of PR is this?

Other

What does this PR do? Why is it needed?

Updates our GoodBye status code messages to match those in Lighthouse.

See
https://github.com/sigp/lighthouse/blob/d7b9d0dd9f4e35680515c0cd0ed437d4e1ad625a/beacon_node/eth2_libp2p/src/rpc/methods.rs#L124

Which issues(s) does this PR fix?

Fixes debug messages like

[2020-10-21 16:19:20] DEBUG sync: Peer has sent a goodbye message Reason=unknown goodbye value of 129 Received peer=16Uiu2HAmVsEc2W1Ed7tZmkSGMou7XGvjDLN3hPsppjVyL8LzJigd

Other notes for review

@prylabs-bulldozer prylabs-bulldozer bot merged commit b4c1c1d into master Oct 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the more-codes branch October 22, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants