Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous Docs Improvements #7606

Merged
merged 10 commits into from Oct 22, 2020
Merged

Miscellaneous Docs Improvements #7606

merged 10 commits into from Oct 22, 2020

Conversation

rauljordan
Copy link
Contributor

This PR fixes a few minor things regarding docs in Prysm:

  • The language for voluntary exits was not clear. People were asked to enter a 'passphrase' found in the docs page, but to some stakers, it sounded like they needed to enter their wallet password. We clarify this bit further in this PR
  • Remove mentions of 'keymanager' in logs in the validator client, as users shouldn't be aware of what that is. Users should only need to know about wallets and that wallets can have different "kinds" such as remote, HD, and imported

@rauljordan rauljordan requested a review from a team as a code owner October 22, 2020 15:22
@rauljordan rauljordan added OK to merge Ready For Review A pull request ready for code review labels Oct 22, 2020
rkapka
rkapka previously approved these changes Oct 22, 2020
View reviewed changes
@prylabs-bulldozer prylabs-bulldozer bot merged commit a688b9e into master Oct 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the docs-fixes branch October 22, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkapka rkapka rkapka approved these changes

@shayzluf shayzluf Awaiting requested review from shayzluf

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

@nisdas nisdas Awaiting requested review from nisdas

@farazdagi farazdagi Awaiting requested review from farazdagi

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

@terencechain terencechain Awaiting requested review from terencechain

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rauljordan @rkapka