Fix Gossip Message ID #7624
Merged
Fix Gossip Message ID #7624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
Codecov Report
@@ Coverage Diff @@
## master #7624 +/- ##
=======================================
Coverage 61.87% 61.87%
=======================================
Files 422 422
Lines 29723 29723
=======================================
Hits 18390 18390
Misses 8418 8418
Partials 2915 2915 |
| h := hashutil.Hash(pmsg.Data) | ||
| return string(h[:]) | ||
| decodedData, err := snappy.Decode(nil /*dst*/, pmsg.Data) | ||
| if err != nil { |
There was a problem hiding this comment.
err != nil feels a bit generic. On a safer side, do you know what specific errors are ok and are not ok?
There was a problem hiding this comment.
Afaik, all errors returned from it should signify it is an invalid snappy object.
https://github.com/golang/snappy/blob/master/decode.go#L57
None of the errors there are 'ok', all point to a corrupted/invalid snappy object as of the spec. If it cant be decoded
it should be appended with the invalid domain and then hashed.
prestonvanloon
approved these changes
Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Addition
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Follows on from ethereum/consensus-specs#2089
Other notes for review