Fix panic issues on beacon node shutdown #7625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
reviewed
Oct 23, 2020
Codecov Report
@@ Coverage Diff @@
## master #7625 +/- ##
=======================================
Coverage 61.87% 61.88%
=======================================
Files 422 422
Lines 29802 29717 -85
=======================================
- Hits 18441 18389 -52
+ Misses 8429 8412 -17
+ Partials 2932 2916 -16 |
I confirm this is the case. |
nisdas
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Fixes a few panics and allows services to gracefully recover when shutting down the beacon node.
Which issues(s) does this PR fix?
Fixes #6924
Other notes for review
N/A